-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check process tree when evaluating whether the shell supporting clearing #48974
Comments
any plans? or can i work on this? |
@cedric05 you can give it a try to see if the performance hit is alright. Here's how I see the implementation working. Basically what we want to do is that when the process title changes, that is this event for macOS/Linux https://github.com/Microsoft/vscode/blob/0c5da80ab2f8af0e94f29af5ffdbfb7b10bdf653/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#L604, shell out to get the process tree under the shell process ( For Windows we're already getting the process tree here https://github.com/Microsoft/vscode/blob/0c5da80ab2f8af0e94f29af5ffdbfb7b10bdf653/src/vs/workbench/parts/terminal/node/windowsShellHelper.ts#L119, we just need to inform Some notes:
|
I'm going to revert this feature, see #49162 (comment) |
Follow up from #48146 (comment)
Running a simple bash script like
while sleep 1; do echo 'a'; done
and then pressing cmd+k will print ^L to the screen. We should check to see if any child processes are there and if so revert back to the standard clear all except the cursor line.The text was updated successfully, but these errors were encountered: