Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn.lock should not be a registered filename in yaml language contributes #50967

Closed
Tracked by #1
JPinkney opened this issue Jun 1, 2018 · 0 comments
Closed
Tracked by #1
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Milestone

Comments

@JPinkney
Copy link

JPinkney commented Jun 1, 2018

Currently yarn.lock is registered as a filename in the yaml language contributes but yarn.lock is not actually valid yaml. Our extension (https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml) provides support for yaml files but is being activated on yarn.lock files despite yarn.lock not being actual yaml.

As far as I can see there is no way to override vscode's language contributes so I request that this line is removed.

@octref octref added the languages-basic Basic language support issues label Jun 1, 2018
@aeschli aeschli added this to the June 2018 milestone Jun 4, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jun 6, 2018
@aeschli aeschli closed this as completed in 13471d3 Jun 6, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants