Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the option to fix centered layout width. #54731

Closed
jonnyso opened this issue Jul 20, 2018 · 21 comments · Fixed by #167568
Closed

Give the option to fix centered layout width. #54731

jonnyso opened this issue Jul 20, 2018 · 21 comments · Fixed by #167568
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded workbench-zen Full screen 'Zen' view issues
Milestone

Comments

@jonnyso
Copy link

jonnyso commented Jul 20, 2018

Previously the centered layout in zen mode had a fixed width, meaning that if you resize the window the centered section will remain the same as long as it still fits in the resized window. The behaviour now is for the centered section width to be proportional to the size of the window. See below:

image

On resize, old behaviour/new behaviour:

image

@vscodebot
Copy link

vscodebot bot commented Jul 20, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn isidorn added feature-request Request for new features or functionality layout General VS Code workbench layout issues labels Jul 20, 2018
@isidorn isidorn added this to the Backlog milestone Jul 20, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 20, 2018

This is a fair feature request. I know @joaomoreno wanted something like this.

@FancyBanana
Copy link
Contributor

I agree, having the editor window resized every time you toggle sidebar is quite annoying for me. It would also be nice to bring back switching back to full-size layout when having more than 1 editor open side by side.

@FancyBanana
Copy link
Contributor

@isidorn I think this issue is closely related to #53989

@bpasero bpasero added workbench-zen Full screen 'Zen' view issues and removed layout General VS Code workbench layout issues labels Aug 6, 2018
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Sep 21, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 21, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 21, 2018
@zhiayang
Copy link

So does this mean that you're not going to address this issue any time in the near future? "Issue grooming" seems to simply be a euphemism for getting rid of issues that nobody wants to fix.

@Gameghostify
Copy link

Can this be reopened? I feel this would be a great change

@isidorn
Copy link
Contributor

isidorn commented Aug 22, 2019

Yes I can reopen.

@isidorn isidorn reopened this Aug 22, 2019
@isidorn isidorn self-assigned this Aug 22, 2019
@isidorn isidorn removed the *out-of-scope Posted issue is not in scope of VS Code label Aug 22, 2019
@Gameghostify
Copy link

@isidorn Thanks a lot!

@yannxaver
Copy link

Any plans on implementing this?

@akbyrd
Copy link
Contributor

akbyrd commented Apr 10, 2020

I love the centered layout feature and I really want to be able to use it. Unfortunately it's unusable as is and I've avoided it for the last couple of years waiting for it to be addressed.

First and foremost, the size must be absolute, not relative. The current behavior is honestly just broken. I can't think of a sane reason why it would be relative. Look at the results:

Sane:
image

Not sane:
image

This is also being asked for here: #71361 (comment)

Second, we need settings for whether to use centered layout and to set the default size. I put in a request for this years ago and it was inexplicably renamed to a completely different request and closed as a duplicate.

P.S. I'm now noticing it's even not centered properly? That's weird...

@isidorn
Copy link
Contributor

isidorn commented Apr 10, 2020

This is a fair feature request and we are open for a lean and good PR that fixes this
Code pointer

this.container.appendChild(this.view.element);

@isidorn isidorn added the help wanted Issues identified as good community contribution opportunities label Apr 10, 2020
@edgarfroes
Copy link

Any plans on implementing this?

@zhiayang
Copy link

Looks like somebody already implemented a PR for it (#104942), but the vscode people decided to close it for petty reasons.

@isidorn isidorn removed their assignment Aug 16, 2021
@fareloz
Copy link

fareloz commented Feb 18, 2022

I miss this feature for almost a year. Any news on when it will be implemented?

@victorvianna
Copy link

Rather than have it be fixed size, I'd rather have the editor adjust to the rulers you define for each file extension. I work in a project where .cc files can have 80 chars, .java can have 100 and my debug logs are unbounded. So whenever I switch I have to adjust the width manually.

@arsdever
Copy link

Does anyone know any workaround until someone finds time to implement it in vscode natively? Any extension that solves this problem?

@lramos15 lramos15 assigned sbatten and unassigned JacksonKearl May 25, 2022
@ma-sadeghi
Copy link

Any updates?

@fareloz
Copy link

fareloz commented Nov 24, 2022

I wrote my comment here back in 2018... now is 2022 and this annoying issue is still here, sadly. Ok, the dev team doesn't want to add such a change to the main code base. But at least give an API to create an extension for those who needs this.

@ma-sadeghi
Copy link

My main issue is the terminal pane. I used to put the terminal pane side by side the editor, and pop it on and off when I needed it. The problem was that in the occasions where I needed both, the editor width was shrunk down to an unusable width due to the centering issue. So, everytime I had to manually switch back and forth between normal and center modes.

Until yesterday, which I gave up and put the terminal at the bottom, so I no longer need to frequently switch to normal mode. It's a pain though, since I lose half the screen height when I need both the editor and the terminal 😟

Please make this an option. There's already an option that automatically turns off the center mode when you open another "window", but it doesn't apply to the terminal pane.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 31, 2023
@rzhao271 rzhao271 modified the milestones: Backlog, February 2023 Feb 21, 2023
@sbatten sbatten added the verification-needed Verification of issue is requested label Feb 22, 2023
@andreamah andreamah added the verified Verification succeeded label Feb 22, 2023
@sbatten sbatten added the on-release-notes Issue/pull request mentioned in release notes label Feb 24, 2023
@thernstig
Copy link
Contributor

@FancyBanana I am going to go out in a limb here and ask if #60900 can be fixed as I find it even more relevant than a fixed width, but subjective of course.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded workbench-zen Full screen 'Zen' view issues
Projects
None yet