Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML formatter adding white space - now fixed on jsbeautify #56205

Closed
chibicode opened this issue Aug 11, 2018 · 2 comments
Closed

HTML formatter adding white space - now fixed on jsbeautify #56205

chibicode opened this issue Aug 11, 2018 · 2 comments

Comments

@chibicode
Copy link

  • VSCode Version: 1.25.1
  • OS Version: 10.13.5

Steps to Reproduce:

  1. Create a document with HTML file type
  2. Insert Hello (World)
  3. Call formatter
  4. There will be a line break after the (, but this will lead to a different rendering of the HTML document.

This is a duplicate of #43520, which I couldn't comment on because it's locked to collaborators.

The news is that the fix now seems to be available on js-beautify.

The PR: beautifier/js-beautify#1407

This fix seems to be available on 1.8.0-rc2 (the latest as of writing is 1.8.0-rc4). beautifier/js-beautify#841 (comment) and beautifier/js-beautify#1033 (comment).

It seems that VSCode is using js-beautify 1.6.8.

@vscodebot
Copy link

vscodebot bot commented Aug 11, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@chibicode
Copy link
Author

Wow, thanks @vscodebot. Sorry I didn't check enough.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant