Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should editComment's text parameter be a MarkdownString? #59349

Closed
chrmarti opened this issue Sep 25, 2018 · 1 comment
Closed

Should editComment's text parameter be a MarkdownString? #59349

chrmarti opened this issue Sep 25, 2018 · 1 comment
Assignees
Milestone

Comments

@chrmarti
Copy link
Contributor

Issue Type: Bug

Testing #59278

Since the API is using MarkdownString in Comment#body too. Maybe also rename the parameter to newBody (or similar) that makes it clearer what it is.

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2, 2018-09-25T07:29:33.175Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (5.66GB free)
Process Argv --user-data-dir /Users/chrmarti/Development/repos/tmp/user2 --extensions-dir /Users/chrmarti/Development/repos/tmp/ext2
Screen Reader no
VM 33%
Extensions: none
@RMacfarlane
Copy link
Contributor

Closing since this version of the proposed API has been removed

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants