Consolidate workbench layout & views/panel persistence

[bpasero]

Once the workbench layout is driven by the grid widget (#50853) I suggest we also revisit how layout information and view/panels are persisted.

Today we are leveraging the following keys (some global, some workspace):

Sidebar

• workbench.sidebar.activeviewletid
• workbench.sidebar.width
• workbench.sidebar.hidden

Panel

• workbench.panelpart.activepanelid
• workbench.panel.width
• workbench.panel.height
• workbench.panel.hidden
• workbench.panel.pinnedpanels
• workbench.panel.sizebeforemaximized
• workbench.panel.location

Activity Bar

• workbench.activity.pinnedviewlets
• workbench.activity.placeholderviewlets

Layout

• editorpart.centeredview
• workbench.centerededitorlayout.active
• workbench.zenmode.active

Splash

• parts-splash-data

View Related

• scm.views
• viewservice.workbench.view.{id}.enablement
• {view-id}.numberOfVisibleViews (e.g. workbench.view.explorer.numberofvisibleviews)
• {view-id}.state (e.g. workbench.explorer.views.state)
• {view-id}.state.hidden (e.g. workbench.explorer.views.state.hidden)
• viewservice.*

I think I would prefer a model where we maybe have just one top level key for this information and then update that when the layout changes. Or at least try to consolidate some keys that belong together.

@sandy081 maybe you yould update the View Related section and outline what purpose these keys serve and if they are required in the future. I am a little bit lost to understand the semantics of the keys you introduced.

[isidorn]

We should also double check when do we write to storage for these keys, I always try to do it on shutdown, but some of those values can change quite frequently, for example sidebar.witdh and we should only store it at the end, not on every change.

If we change it for one key it might be complicate some things since currently we write from different locations. Also every write would have to write additional information - not sure if that slows things down.

[bpasero]

@isidorn yeah, though to be fair the storage implementation buffers calls and also will not do anything if the value is equal. The downside of only writing global keys on shutdown is that opening a new window will not get the proper layout values.

[bpasero]

Another idea is to leverage our memento story better: each workbench part has access to a object to store data and this object will automatically be stored and restored and scoped to the part with its ID. I think it would make more sense to e.g. put the active viewlet and number of pinned viewlets into the sidebar memento (same for panel memento). We should then continue to leverage mementos also for individual views within a viewlet.

[vscodebot]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!