Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test support for "related resources" in loadedScripts view #62093

Closed
2 tasks done
weinand opened this issue Oct 29, 2018 · 0 comments
Closed
2 tasks done

Test support for "related resources" in loadedScripts view #62093

weinand opened this issue Oct 29, 2018 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Oct 29, 2018

Test for #62034:

Complexity: 2

Authors: @weinand

The loaded scripts view now shows related resources as children and node-debug (legacy) returns source-map sources as "related resources" via DAP.

In addition the elements of the loaded scripts view now support icon themes (only exception: top level session nodes have no icons because icon themes don't provide session icons).

The resulting UI looks like this:

2018-10-29_22-54-13

Setup:

  • debug a project that transpiles to JS and has source maps,
  • since this feature is only implemented in node-debug (legacy) use a node.js version < 8.0 (e.g. by using "runtimeVersion": "7.10.1" in the launch config.

A good example is the node-debug (legacy) itself (e.g. its "Server" launch config).

Verify:

  • source is shown as children of its corresponding JS
  • scripts and related resources show correct icons and hovers
  • selecting related resources opens the correct source in the editor
  • setting breakpoints in related resources works
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

3 participants