Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug consoles cannot be deleted #62418

Closed
weinand opened this issue Nov 1, 2018 · 4 comments
Closed

Debug consoles cannot be deleted #62418

weinand opened this issue Nov 1, 2018 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Nov 1, 2018

VS code Insiders

  • run cluster example
  • stop all processes

Observe: there are many debug consoles but no way to get rid of them

screenshot 2018-11-01 at 22 32 44

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Nov 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 2, 2018

This is by design. I think this should simply be fixed via #62419

Closign this for now, we can reopen in the future if 62419 proves to not be a good solution

@isidorn isidorn closed this as completed Nov 2, 2018
@isidorn isidorn added the *as-designed Described behavior is as designed label Nov 2, 2018
@weinand
Copy link
Contributor Author

weinand commented Nov 2, 2018

Since Integrated terminals can be deleted, the same should be possible for debug consoles.

Disabling multiple debug consoles doesn't help in deleting them if you want to use them and git too many of them.

@weinand weinand reopened this Nov 2, 2018
@weinand weinand added this to the November 2018 milestone Nov 2, 2018
@weinand weinand removed the *as-designed Described behavior is as designed label Nov 2, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 12, 2018

We will add a title bar action to delete only when there is more than I console.
Deleting the console, only delets the console it does not interact with the running session in any way

@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Nov 12, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 12, 2018

We have decided not to render a new action delete, but instead to not show inactive debug console which got cleared.
This in practice means that you can press clear to get rid of outdated debug consoles.

To verify

  1. Start debugging two debug sessions in the same time
  2. Stop debugging them
  3. Make sure that pressing clear removes the cleared debug console and that you can get rid of all except the last one standing

@roblourens roblourens added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants