Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiline search improvements #64270

Closed
3 tasks done
roblourens opened this issue Dec 4, 2018 · 0 comments
Closed
3 tasks done

Test multiline search improvements #64270

roblourens opened this issue Dec 4, 2018 · 0 comments

Comments

@roblourens
Copy link
Member

roblourens commented Dec 4, 2018

Test #62961 and #62304

Complexity: 3

This only applies to the search view, there are no changes to the editor find widget.

  • The search and replace inputs should expand to fit multiple lines of text, up to some max, and they can scroll after that
  • They expand on typing or pasting text in, and collapse to the right size when the input shrinks
  • shift+enter should insert a newline, enter should start the search
  • Multiple lines of text should match whether in regex mode or not
  • up/down arrow keys should move the cursor within the text input, but when it gets to the top or bottom of the input, they should navigate to the next/previous item in history
  • If you copy multiple lines of text and press cmd+shift+f, they should be copied into the search input
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants