Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable key bindings to any task #6550

Closed
justin-romano opened this issue May 19, 2016 · 17 comments
Closed

Allow configurable key bindings to any task #6550

justin-romano opened this issue May 19, 2016 · 17 comments
Assignees
Labels
feature-request Request for new features or functionality tasks Task system issues
Milestone

Comments

@justin-romano
Copy link

For instance. I would like to assign key binding to any task
Other than just test and build.
for instance

  {
    "key": "ctrl+shift+1",
    "command": "workbench.action.tasks.task1"
  }
@dbaeumer dbaeumer added tasks Task system issues feature-request Request for new features or functionality labels May 23, 2016
@dbaeumer dbaeumer added this to the June 2016 milestone May 23, 2016
@dbaeumer
Copy link
Member

This is actually a nice idea to solve this.

@alexandrudima can I have arguments to a command in the key bindings file. I would like to name the action workbench.actions.task and then have an argument "task1"

@dbaeumer
Copy link
Member

@alexandrudima ping...

@dbaeumer dbaeumer modified the milestones: August 2016, June 2016 Jun 30, 2016
@dbaeumer
Copy link
Member

Moving. Was very busy with the TS builder exploration.

@alexdima
Copy link
Member

alexdima commented Aug 9, 2016

@dbaeumer Not yet, but it is something I wanted to do since more than 1 year. :)

@dbaeumer
Copy link
Member

@codyrigney92 is working on this here: #10676, but PR is not ready yet. Moving to September.

@dbaeumer
Copy link
Member

No progress on the pull request. Moving to October.

@dbaeumer
Copy link
Member

No progress on PR. Moving to November

@ramya-rao-a
Copy link
Contributor

@dbaeumer There is progress on the PR, will we be taking this for the current milestone or pushing to Jan 2017?

@dbaeumer dbaeumer modified the milestones: January 2017, November 2016 Dec 6, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Dec 6, 2016

Unfortunately I was not able to get this into November given the LSP work I had to do. For January we want to completely revisit the way tasks work. See the discussion here: #15179. I will make sure that this will make it into the new design.

@dbaeumer
Copy link
Member

I re-implemented the task execution engine for Jan to use the terminal instead of the output window. Although not the default yet I will wait until the switch is final to provide support for this request With the new engine this needs more thinking since the new engine support executing tasks in parallel and to compose task out of smaller tasks. I first need to finalize the syntax in the tasks.json for this before allowing to bind key bindings for the composite tasks. Otherwise I might break clients unnecessarily.

@dbaeumer dbaeumer modified the milestones: February 2017, January 2017 Jan 23, 2017
@dbaeumer
Copy link
Member

This will be available in the next version of VS Code.

	{
		"key": "ctrl+h",
		"command": "workbench.action.tasks.runTask",
		"args": "tsc"
	}

@origin1tech
Copy link

This is just outstanding...VSCode becoming gold std. IDE.

@cbrianball
Copy link

Agreed, this opens up a lot of options for me!

@raldred
Copy link

raldred commented Apr 23, 2017

@dbaeumer is this implemented in 1.11? There was a comment on #10676 that it was due in 1.10.
Doesn't seem to work as per docs:
https://code.visualstudio.com/docs/editor/tasks#_binding-keyboard-shortcuts-to-tasks

@dbaeumer
Copy link
Member

This is in but there seems to be problems with it for 1.11.x. I have a bug for it and will investigate.

@raldred
Copy link

raldred commented Apr 25, 2017

Thought i was going crazy. Thanks @dbaeumer

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality tasks Task system issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants