[json] $ref breaks validation of additionalItems

[openreply-dleinhaeuser]

• VSCode Version: 1.31.1
• OS Version: macOS 10.14.2

Steps to Reproduce:

1. Create a JSON-Schema where a $ref is used inside additionalItems

{
  "type": "array",
  "items": [
    {
      "type": "string"
    }
  ],
  "additionalItems": {
    "$ref": "#/definitions/Number"
  },
  "definitions": {
    "Number": {
      "type": "integer"
    }
  }
}

2. Create a JSON file where the additional items in the array do not conform to the schema

[
  "A string",
  "Definitely not an integer"
]

3. Set VSCode up to validate the JSON file against the schema

Expected result:

Squiggly lines below the second item in the array.

Actual result:

JSON file passes validation

Does this issue occur when all extensions are disabled?: Yes

[paillave]

Any news about this bug?

actually anything that is in additionalItems that is not "true" or a simple type ("number", "string", etc...) is ignored. Type "object" with its properties, or a reference is just ignored.

At my side

{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "title": "Container",
  "type": "object",
  "additionalProperties": false,
  "properties": {
    "Stream": {
      "$ref": "#/definitions/Stream"
    }
  },
  "definitions": {
    "Stream": {
      "type": [
        "array"
      ],
      "items": [
        {
          "$ref": "#/definitions/Input"
        }
      ],
      "additionalItems": {
        "$ref": "#/definitions/Pipe"
      }
    },
    "Input": {
      "type": "object",
      "oneOf": [
        {
          "$ref": "#/definitions/Input1"
        },
        {
          "$ref": "#/definitions/Input2"
        }
      ]
    },
    "Input1": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
        "Type": {
          "type": "string",
          "enum": [
            "Input1"
          ]
        },
        "Prop1": {
          "type": "integer",
          "format": "int32"
        },
        "Name": {
          "type": "string",
          "minLength": 1
        }
      }
    },
    "Input2": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
        "Type": {
          "type": "string",
          "enum": [
            "Input2"
          ]
        },
        "Prop2": {
          "type": "integer",
          "format": "int32"
        },
        "Name": {
          "type": "string",
          "minLength": 1
        }
      }
    },
    "Pipe": {
      "type": "object",
      "oneOf": [
        {
          "$ref": "#/definitions/Pipe1"
        },
        {
          "$ref": "#/definitions/Pipe2"
        }
      ]
    },
    "Pipe1": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
        "Type": {
          "type": "string",
          "enum": [
            "Pipe1"
          ]
        },
        "NumberOfLegs": {
          "type": "integer",
          "format": "int32"
        },
        "Name": {
          "type": "string",
          "minLength": 1
        }
      }
    },
    "Pipe2": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
        "Type": {
          "type": "string",
          "enum": [
            "Pipe2"
          ]
        },
        "NumberOfWings": {
          "type": "integer",
          "format": "int32"
        },
        "Name": {
          "type": "string",
          "minLength": 1
        }
      }
    }
  }
}

validated json that should not be accepted:

{
    "Stream": [
        {
            "Type": "Input1",
            "Name": "qsdfgf",
            "Prop1": 45
        },
        "not only these is no intellisense",
        "but it also validates!",
        {
            "prop1": "anything",
            "prop2": "is validated"
        },
        54
    ]
}