Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a replacement communication service for EH debugging #70835

Closed
weinand opened this issue Mar 20, 2019 · 8 comments
Closed

Create a replacement communication service for EH debugging #70835

weinand opened this issue Mar 20, 2019 · 8 comments
Assignees
@isidorn
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
April 2019

Comments

@weinand
Copy link
Contributor

weinand commented Mar 20, 2019

see #70831
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Mar 20, 2019
@weinand weinand mentioned this issue Mar 20, 2019
Closed
@isidorn isidorn added this to the April 2019 milestone Mar 22, 2019
@bpasero
Copy link
Member

bpasero commented Mar 25, 2019

The messages are:

  • vscode:extensionLog
  • vscode:extensionCloseExtensionHost
  • vscode:extensionReload
  • vscode:extensionAttach
  • vscode:extensionTerminate

(in src/vs/platform/extensions/common/extensionHost.ts which then maybe also should go away)

@isidorn
Copy link
Contributor

isidorn commented Mar 25, 2019

Yeah, thanks. I will get rid of that file.

@isidorn isidorn closed this as completed in 2506981 Apr 3, 2019
@isidorn
Copy link
Contributor

isidorn commented Apr 3, 2019

I have introduce the ExtensionHostDebugService.
IMHO now the communication is much nicer and has more type safety.

@jrieken @bpasero @weinand feedback welcome

@bpasero
Copy link
Member

bpasero commented Apr 4, 2019

@isidorn can you move that code into workbench/contrib/debug? workbench/services should be used for things that are used by the core workbench and debug seems like it only exists as a contribution to the workbench.

@isidorn
Copy link
Contributor

isidorn commented Apr 4, 2019

Makes sense, @weinand gave the same feedback.
Let me move it.

@isidorn
Copy link
Contributor

isidorn commented Apr 4, 2019 •
edited
Loading

@bpasero acutally I can not move it. Since the extensionHost.ts depends on it. And from there I can not depend on vs/workbench/contrib/. I get an import violates warning.

@bpasero
Copy link
Member

bpasero commented Apr 4, 2019

Yeah true. I moved it into the services/extensions folder at least.

@isidorn
Copy link
Contributor

isidorn commented Apr 4, 2019

Ok, thanks.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
April 2019
Development

No branches or pull requests
3 participants
@bpasero @weinand @isidorn