Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Env no longer inherited by tasks #71826

Closed
spmeesseman opened this issue Apr 5, 2019 · 4 comments
Closed

Process Env no longer inherited by tasks #71826

spmeesseman opened this issue Apr 5, 2019 · 4 comments
Assignees

Comments

@spmeesseman
Copy link

Tested with insiders, bug still present.

  • VSCode Version: 1.33.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Install 1.33.0. Process environment is no longer inherited by shell tasks (defined in tasks.json).
  2. Unzip 1.32.3 over the 1.33 install, environment once again is inherited by shell tasks.
  3. Unzip 1.34 Insiders over the install, problem returns.
  4. Launch with --disable-extensions, problem remains.
  5. Put 1.32.3 back, problem gone.

If this isnt a bug what changed that I need to do now? I combed the release notes but found nothing.

Does this issue occur when all extensions are disabled?: No

@spmeesseman
Copy link
Author

Just a follow up note.... A team of 14 here, no one can update because this problem is affecting ALL of our builds. We spent days and days making VSCode task files when we switched to VSCode, now none of them work in this version since there is no environment inherited.

@vscodebot vscodebot bot removed the new release label Apr 9, 2019
@spali
Copy link

spali commented Apr 9, 2019

can reproduce this exactly the same way with the integrated terminal in general.
using something like this in the settings

  "terminal.integrated.env.windows": {
    "Path": "${env:Path}",
  }

wipes out the whole path variable because ${env:Path} is always empty.
before 1.33 it works as expected.

@davidwin
Copy link

Looks like #72029

@spmeesseman
Copy link
Author

fixed in 1.33 Recovery 1

@vscodebot vscodebot bot locked and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants