Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the popups corresponding to the diagnostics in Problems List to show custom markdown content #74632

Closed
samrat-gavale opened this issue May 30, 2019 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@samrat-gavale
Copy link

Issue Type: Feature Request

Currently in the problems list feature, on hovering the squiggle that marks corresponding line in editor, a popup is shown with the same text as that in the diagnostic item in the problems list. Our extension wants to show more detailed markdown content in the popup, which would be different from that in the item in the problems list.

Below is our current experience. Using a decoration, our extension highlights a line and provides rich information about the code on that line in a pop-up. We provide external links within that pop-up and thus require Markdown. To make it easier to the user to find the highlighted lines and pop-ups, we also put them in the Problems list. However, now we have both a highlight and a squiggle and the pop-up shows our rich information in addition to the actual (non-Markdown) text from the Problems list item. We’d like to eliminate the redundant highlight and data and have a single experience/API, hence this request.

image

I am aware of issue 64566 and issue 54272 which talk about extending the Problems List to allow markdown in the individual diagnostic messages itself, but our requirement is to have a short message in the diagnostic (as we have now) and a markdown based message in the popup revealed on hovering the squiggle tied to that diagnostic.

If this looks like an acceptable extension to existing Problems list functionality, I can go ahead and make the required changes and create a pull request.

cc: @sandy081

VS Code version: Code 1.34.0 (a622c65, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.18908

@vscodebot vscodebot bot added the markdown Markdown support issues label May 30, 2019
@mjbvz mjbvz removed the markdown Markdown support issues label Jun 4, 2019
@mjbvz mjbvz assigned sandy081 and unassigned mjbvz Jun 4, 2019
@sandy081
Copy link
Member

@samrat-gavale This is a duplicate of #54272. We had a discussion recently with the typescript team where they are looking for similar support - to support rich diagnostic message and mainly links. And they are working on some prototype for that. @mjbvz Can you please let us know what is the latest state on this from typescript team so that all of us can be in sync.

Regarding implementing this, it is easy to support markdown message in the editor but since we also show the same in problems panel, it requires some thinking on how to show there.

Please continue discussion in other item.

/duplicate.

@sandy081
Copy link
Member

/duplicate

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 28, 2019
@vscodebot
Copy link

vscodebot bot commented Jun 28, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants