-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minifier for core code #79433
Comments
I am adding you @chrmarti because you did this update already and have learned what the consequences where (I think with some language definitions) that you should share here. I personally feel we should jump to a minifier that is active and maintained, so there is a bit of research required here. So far I heard of (not necessarely active anymore): |
Jumping out of this since my engineering plate is as full as my actual plate at a Brazilian BBQ. |
Might make sense to use Terser like we do for extensions. That way we would get consistent behavior for all our code. Article comparing minifiers: https://blog.logrocket.com/uglify-vs-babel-minify-vs-terser-a-mini-battle-royale/. |
@chrmarti I have a branch up for using Terser: https://github.com/microsoft/vscode/compare/ben/terser To workaround the issue we noticed when you tried to go with latest Maybe you can verify that your minification issue is resolved with terser. |
via #80201 |
I am running a build with the new minifier and with restoring |
We have seen two instances of a bug in uglify-es (#79044, #74321) that appears to be fixed in the latest version of the minifier. Updating to that caused some issues and the project seems to be abandoned atm (1.5 years old release), so I didn't invest additional time.
We need to look into updating to an actively maintained minifier supporting ES6.
/cc @joaomoreno @bpasero
The text was updated successfully, but these errors were encountered: