Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test deprecated symbols/completions #79814

Closed
2 tasks done
jrieken opened this issue Aug 26, 2019 · 3 comments
Closed
2 tasks done

Test deprecated symbols/completions #79814

jrieken opened this issue Aug 26, 2019 · 3 comments

Comments

@jrieken
Copy link
Member

jrieken commented Aug 26, 2019

re #50972

Complexity: 4

There is now support to tag completions and symbols as deprecated. Such items get a special rendering, namely

  • get a strike out
  • are dimmed
  • don't render match highlights

To test, write an extension that implements a CompletionItemProvider, a DocumentSymbolProvider, and a WorkspaceSymbolProvider and let them return results using the proposed API of CompletionItemTags and SymbolTags. The deprecated tag should be honoured in

  • quick outline (cmd+shift+o)
  • the outline tree
  • workspace symbol search (cmd+t)
  • IntelliSense
@jrieken
Copy link
Member Author

jrieken commented Aug 26, 2019

fyi - use the vscode-dts-utility to use the latest version of vscode.d.ts and/or vscode.proposed.d.ts

@octref
Copy link
Contributor

octref commented Aug 27, 2019

What does "don't render match highlights" mean?

@jrieken
Copy link
Member Author

jrieken commented Aug 28, 2019

What does "don't render match highlights" mean?

When matching a query/prefix against an item we render matches bold and blue. For deprecated items that isn't happening

Screenshot 2019-08-28 at 09 34 34

@weinand weinand removed their assignment Aug 28, 2019
@weinand weinand closed this as completed Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants