Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between newline of search between file and workspace #80361

Closed
Thaina opened this issue Sep 5, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Closed
Assignees
Labels
debt Code quality issues

Comments

@Thaina
Copy link

Thaina commented Sep 5, 2019

Latest version 1.38 introduce ability to add new line into search. Which is really great. But it also introduce ctrl+enter that was differ from workspace search that use shift+enter

I would like to voice that we should use the same everywhere. And so we should use ctrl+enter to add newline in workspace search too from the next version. We should also discourage usage of shift+enter for new line in some way (such as popup notice about deprecation) then remove it in some future version

@roblourens
Copy link
Member

ctrl+enter is currently used for "replace" on windows but we need to find a way forward to unify these.

@roblourens roblourens added the debt Code quality issues label Sep 9, 2019
@roblourens roblourens added this to the September 2019 milestone Sep 9, 2019
@Thaina
Copy link
Author

Thaina commented Sep 10, 2019

Maybe opposite that we should use shift+enter everywhere. But then we need to find new key to select previous search

Maybe ctrl+arrow ?

@roblourens
Copy link
Member

I don't think we should replace shift+enter in the find widget. And I'm not sure that there's really an issue with ctrl+enter in search anyway. Just need a little investigation.

@Thaina
Copy link
Author

Thaina commented Sep 11, 2019

@roblourens I actually wish we could use shift+enter for newline in find widget. Because it was consistent with majority of app that need to make newline (such as chat app) so it more familiar

I just know that people may already adapt to current behaviour of our shift+enter so at first I suggest ctrl+enter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants