Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "uniqueItems" in configuration UI #80536

Closed
letmaik opened this issue Sep 8, 2019 · 0 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Support "uniqueItems" in configuration UI #80536

letmaik opened this issue Sep 8, 2019 · 0 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@letmaik
Copy link
Member

letmaik commented Sep 8, 2019

     "myext.option": {
          "type": "array",
          "uniqueItems": true,
          "items": {
            "type": "string",
            "enum": [
              "A",
              "B"
            ]
          }
      }

A value of "myext.option": ["A", "A"] shows up as error ("Array as duplicate items") in the JSON view but not in the UI view. Both views should have consistent errors.

@roblourens roblourens assigned octref and unassigned roblourens Sep 9, 2019
@octref octref added this to the September 2019 milestone Sep 9, 2019
@octref octref added settings-editor VS Code settings editor issues feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Sep 9, 2019
@octref octref closed this as completed in 55825e9 Sep 9, 2019
@alexr00 alexr00 added the verified Verification succeeded label Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants