Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting for disabling link protection #80592

Closed
akbyrd opened this issue Sep 9, 2019 · 11 comments
Closed

Add a setting for disabling link protection #80592

akbyrd opened this issue Sep 9, 2019 · 11 comments
Assignees
Labels
*as-designed Described behavior is as designed verified Verification succeeded workbench-link Link protection in workbench

Comments

@akbyrd
Copy link
Contributor

akbyrd commented Sep 9, 2019

It looks like the fancy new feature asking me if I really really meant to click a link doesn't have a setting to disable it (inside my settings.json). I really don't want to have to deal with disabling this manually on every machine I end up using.

@octref octref added the bug Issue identified by VS Code Team member as probable bug label Sep 11, 2019
@octref octref added this to the September 2019 milestone Sep 11, 2019
@octref octref added the *as-designed Described behavior is as designed label Sep 15, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 15, 2019

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@octref octref removed the bug Issue identified by VS Code Team member as probable bug label Sep 15, 2019
@vscodebot vscodebot bot closed this as completed Sep 15, 2019
@octref
Copy link
Contributor

octref commented Sep 15, 2019

Extensions can write to your settings, so we don't want to allow configuring this in settings. You can run the new command "Toggle Link Protection for Trusted Domains".

@akbyrd
Copy link
Contributor Author

akbyrd commented Sep 16, 2019

I don't want this "feature".

@octref
Copy link
Contributor

octref commented Sep 16, 2019

There's a legal requirement for Microsoft software for linking to websites that Microsoft has no control on.

@akbyrd
Copy link
Contributor Author

akbyrd commented Sep 16, 2019

Fine, but give me control over my own experience. I don't want or need this feature and now it's something I have to fuss with on every single install. Which ends up being relatively frequent on work machines.

@octref
Copy link
Contributor

octref commented Sep 16, 2019

Yeah, unfortunately you would have to do it at least once on each machine. But the requirement is MS product has to acquire explicit user consent before it can direct users to other domains it has no control of.

@akbyrd
Copy link
Contributor Author

akbyrd commented Sep 17, 2019

Unfortunate, yes. I started using VS Code because it didn't get in my way and I was able to stay in the zone and productive longer than with, say, Visual Studio. However, it's steadily creeping up in little annoyances that add up to an unpleasant experience and this is right at home in the list. This is, however, the most direct and egregious example as it is literally a company decision to get in the users way and stop them from doing their work. Yes, it's small, but these things matter.

I understand this has next to zero percent chance of changing and I'm talking into the void.

@aeschli aeschli added the verified Verification succeeded label Oct 2, 2019
@kbd
Copy link

kbd commented Oct 3, 2019

Yeah, unfortunately you would have to do it at least once on each machine.

Would it be possible to expose this as a command-line option? This way I could include a call to (eg.):

$ code --disable-link-protection

as part of my automated system setup so I don't need to change this setting on every machine.

Or could extensions still call the command-line option to get around this?

@octref
Copy link
Contributor

octref commented Oct 3, 2019

code --disable-link-protection

I don't think that's a good addition. However our upcoming setting sync work should include syncing this hidden setting.

@kbd
Copy link

kbd commented Oct 3, 2019

However our upcoming setting sync work should include syncing this hidden setting.

I didn't know there is work ongoing on official settings sync. Would you mind linking the issue for settings sync so I can read about it?

The current settings sync extension is less-than-ideal, so I check my keybindings.json, settings.json, and global.code-snippets into source control. Will it be possible to sync just "system" settings that are uncontrollable through settings.json (I'd prefer to maintain my current source control setup) or will it be all-or-nothing? Thanks.

@octref
Copy link
Contributor

octref commented Oct 3, 2019

@kbd #78869 and #78966. You can always find latest work in the pinned Iteration Plan:

image

@octref octref added the workbench-link Link protection in workbench label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed verified Verification succeeded workbench-link Link protection in workbench
Projects
None yet
Development

No branches or pull requests

4 participants