Touch Bar displays text instead of icons on Insider build

[keeganwitt]

Stable (August 2019, version 1.38.1) shows

But the current Insider build (fa2b3c3) shows

It's unclear whether this change was intentional or not. If it was intentional, think about the impact that'd have on extensions that add additional features to the touch bar, such as

https://marketplace.visualstudio.com/items?itemName=blairleduc.touch-bar-display

https://marketplace.visualstudio.com/items?itemName=felipe.nasc-touchbar

https://marketplace.visualstudio.com/items?itemName=ashhitch.touchbar-command-palette

On the Insider build, none of these are able to show their buttons (I think because there's insufficient space now that the icons are text).

[kieferrm]

This is a regression in the latest insider. We'll release a new insider build shortly.

[jtsom]

FYI.,.. it's been like this for the past few versions, and the latest, just released still has text labels:

Version: 1.39.0-insider
Commit: 6a54c8176fd60745ad7f2ba9dc89af4631752bae
Date: 2019-09-18T15:26:55.541Z

[miguelsolorio]

cc @bpasero @isidorn

I wonder if this has something to do with our builds or a new version of Electron. On Insiders I see:

And on master I see:

This doesn't repro on Stable.

[miguelsolorio]

Upon further inspecting the build bits, it appears that on Stable the icons are there:

But on Insiders they are missing:

So they're not being included during the build process. The last Insiders build where it was working was:

Version: 1.39.0-insider
Commit: 0f1bd77
Date: 2019-09-09T05:26:48.181Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

@isidorn maybe this commit is the culprit? It's the last time these files were updated for the Touch Bar? a33e554

[keeganwitt]

FYI.,.. it's been like this for the past few versions, and the latest, just released still has text labels:

Version: 1.39.0-insider
Commit: 6a54c8176fd60745ad7f2ba9dc89af4631752bae
Date: 2019-09-18T15:26:55.541Z

Yea, I should have been clearer. You're right, it's been this way a while. What I meant was that it still present in the latest build, not that it started in the latest build. Thanks for clarifying.

[bpasero]

It looks like all the touchbar icons are missing from the insiders drop.

[eamodio]

I don't know if its 100% related, but I'm also seeing other icons missing with the latest insiders (and it was present in the last couple builds).

Collapse All icon is missing:

Back arrow icon is missing:

[isidorn]

1. Works in stable
2. Wors out of source
3. Does not work in insiders, as icons are not there as you mentioned.

Checking if a33e554 broke this

[isidorn]

Ok it seems like the native mac touch bar does not allow icons which are contributed there to be inlined. So I will remove our call to registerAndGetAmdImageURL when we contribute icons for the native mac touch bar. Verifyign if this indeed fixes the issue