-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch Bar displays text instead of icons on Insider build #81111
Comments
This is a regression in the latest insider. We'll release a new insider build shortly. |
FYI.,.. it's been like this for the past few versions, and the latest, just released still has text labels:
|
Upon further inspecting the build bits, it appears that on Stable the icons are there: But on Insiders they are missing: So they're not being included during the build process. The last Insiders build where it was working was: Version: 1.39.0-insider @isidorn maybe this commit is the culprit? It's the last time these files were updated for the Touch Bar? a33e554 |
Yea, I should have been clearer. You're right, it's been this way a while. What I meant was that it still present in the latest build, not that it started in the latest build. Thanks for clarifying. |
It looks like all the touchbar icons are missing from the insiders drop. |
Checking if a33e554 broke this |
Ok it seems like the native mac touch bar does not allow icons which are contributed there to be inlined. So I will remove our call to |
Stable (August 2019, version 1.38.1) shows
But the current Insider build (fa2b3c3) shows
It's unclear whether this change was intentional or not. If it was intentional, think about the impact that'd have on extensions that add additional features to the touch bar, such as
https://marketplace.visualstudio.com/items?itemName=blairleduc.touch-bar-display
https://marketplace.visualstudio.com/items?itemName=felipe.nasc-touchbar
https://marketplace.visualstudio.com/items?itemName=ashhitch.touchbar-command-palette
On the Insider build, none of these are able to show their buttons (I think because there's insufficient space now that the icons are text).
The text was updated successfully, but these errors were encountered: