Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more functionality to the "vscode.workspace.fs" API. #84175

Closed
ericsnowcurrently opened this issue Nov 8, 2019 · 3 comments
Closed

Add more functionality to the "vscode.workspace.fs" API. #84175

ericsnowcurrently opened this issue Nov 8, 2019 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality file-io File I/O

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 8, 2019

I'm working on using the new "vscode.workspace.fs" API in the Python extension. There are some things we do for which we'd like to use the new API, but it doesn't provide the needed functionality. I'll list them here, but would be glad to open a separate issue for each if that would help.

(Also see #84177 for possible bugs in the new API.)

@jrieken
Copy link
Member

jrieken commented Nov 8, 2019

  • chmod() - currently using node's fs.chmod() dupe of Enable FileSystemProvider to stat a file as readonly #73122
  • lstat() - currently using node's fs.lstat() dupe of File Provider: support symbolic link operations #71204
  • createWriteStream() - currently using node's fs.createWriteStream() -> we have some proposed api but nothing is final yet. @ericsnowcurrently What is the used for? Real big files or just because?
  • statSync() - currently using node's fs.statSync()
  • readFileSync() - currently using node's fs.readFileSync() Our design/architecture prohibits anything sync here. This will not happen.
  • mkdirp() - currently wrote a wrapper around the new createDirectory()
    • was using fs-extra's mkdirp(), but could have used node's mkdir() with the "recursive" option set to true
  • mkdtemp() - currently using "tmp" (tmp.file()), but could have used node's fs.mkdtemp()
  • glob() - currently using "glob" - use findFiles
  • probably others

@jrieken
Copy link
Member

jrieken commented Nov 8, 2019

@ericsnowcurrently for the future: one ask -> one issue.

@ericsnowcurrently
Copy link
Member Author

Sorry about that, @jrieken. I've opened separate issues for the various items.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-io File I/O
Projects
None yet
Development

No branches or pull requests

3 participants