Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not try to reconnect on real quit #855

Closed
weinand opened this issue Dec 1, 2015 · 2 comments
Closed

do not try to reconnect on real quit #855

weinand opened this issue Dec 1, 2015 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Dec 1, 2015

I think we should start to look into a solution to this because we are now adding workarounds for this issue when running unit tests: The issue is that when the unit test is done, I quit the PH with process.exit(). This nicely closes the window but the debugger wants to reconnect right after and fails (not with an error message, but its weird to see the debug viewlet progress spinning for 2 seconds).

We also see this when you Cmd+Q the extension host to terminate the session.

I am open to ideas what to do here, somehow the PH needs to signal back how it was terminated.

@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Dec 1, 2015
@weinand weinand added this to the Dec 2015 milestone Dec 1, 2015
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 1, 2015
@isidorn
Copy link
Contributor

isidorn commented Dec 1, 2015

I have exposed the raw attach in my debug api, Ben will try it out and we see if something else is needed.

@egamma
Copy link
Member

egamma commented Dec 4, 2015

Update from @weinand

We have finished the restructuring work on ExtensionHost (EH) debugging and I've verified that it works on OS X, Windows, and Linux.
It feels snappier and the VS Code debugger no longer waits 5 seconds after the user has closed the EH window.

The only remaining issue I've seen so far is that on Windows pressing the red debug Stop button, doesn't close the EH window.
So you have to close the EH window manually.
This seems to be a timing issue and I'll investigate right after this mail (It is a Heisenbug that does not occur when trying to debug the problem...).

@isidorn isidorn closed this as completed Dec 4, 2015
@isidorn isidorn added the verified Verification succeeded label Dec 15, 2015
@egamma egamma mentioned this issue Jan 6, 2016
59 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants