Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to drag and drop breakpoints #88227

Open
ariffjeff opened this issue Jan 7, 2020 · 12 comments
Open

Ability to drag and drop breakpoints #88227

ariffjeff opened this issue Jan 7, 2020 · 12 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@ariffjeff
Copy link

Issue Type: Feature Request

The ability to move breakpoints, especially those that are conditional, would be considerably easier than having to delete a breakpoint and then recreate it with the same condition information on another line. Drag and drop functionality would work pretty well here I imagine.

VS Code version: Code 1.41.1 (26076a4, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362

@weinand weinand assigned isidorn and unassigned weinand Jan 7, 2020
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Jan 7, 2020
@weinand weinand added this to the On Deck milestone Jan 7, 2020
@weinand
Copy link
Contributor

weinand commented Jan 7, 2020

yes, this would improve the usability of "rich" breakpoints.

@isidorn
Copy link
Contributor

isidorn commented Jan 8, 2020

Agree, this is a fair feature request.

@ariffjeff
Copy link
Author

As an added thought: For cases of files that are hundreds or thousands of lines long, it would probably be a good idea to be able to enter in a line number you want to move a breakpoint to instead of having to click and drag it over an entire document. The Breakpoints dropdown already displays the line numbers for each breakpoint so double clicking or right clicking them is perhaps the best way to enter line number values?

@joerohde
Copy link

This is becoming more frustrating as I use conditional breakpoints more and more.

It's a big break in flow to display/copy/re-create-condition-breakpoint/paste when I want to drag it down a line.

Also clicking or double clicking the line number in the breakpoints panel and having a context menu item for changing the line number in that panel would be a bonus.

@weinand weinand modified the milestones: On Deck, April 2020 Apr 10, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2020

Overall this feature request makes sense, however this is a short iteration thus I do not think I will have time to tackle this milestone. Due to that pushing to May.

@isidorn isidorn modified the milestones: April 2020, May 2020 Apr 20, 2020
@isidorn
Copy link
Contributor

isidorn commented May 12, 2020

This iteration is even shorter due to holidays. Thus pushing to on-deck and we would put this back on the plan when we have cycles.

@isidorn
Copy link
Contributor

isidorn commented Jan 22, 2021

I have a simple version of this working #114717
However for more powerfull support where we are able to render images while dragging and to be able to drag between multiple editors we would need this as a prerequest #114776
Due to that moving this item to next milestone

@isidorn isidorn modified the milestones: March 2021, April 2021 Mar 22, 2021
@alefragnani
Copy link

Hi @isidorn ,

Are there any chances of exposing this drag and drop capability/event to Decorators as well, so extensions could also subscribe?

Thank you

ps: I did search the open issues about it, but didn't find any 😬

@isidorn
Copy link
Contributor

isidorn commented Apr 6, 2021

@alefragnani yes it would be possible, but we would first do the breakpoint in the core and only after that potential add this if there is enough extensions interested.. It would be best if you file a new issue. Thanks

@OneLookSigns
Copy link

@isidorn Further functionality could be to also allow Control + Drag so that breakpoints with conditional information can be duplicated to other lines.

@johncrim
Copy link

Could the scope of this be expanded to include logpoints? (IMO drag + drop is more valuable for conditional breakpoints and logpoints than standard breakpoints, due to the effort required today to change/move them). If yes, then I can close #182133 as a dup.

@jetpackguy
Copy link

Please make it happen 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

9 participants