Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Link provider-based terminal links #96299

Closed
2 tasks done
Tyriar opened this issue Apr 27, 2020 · 1 comment
Closed
2 tasks done

Test: Link provider-based terminal links #96299

Tyriar opened this issue Apr 27, 2020 · 1 comment

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2020

Refs: #95081, #90298, #29499

Complexity: 4


How links in the terminal work have changed a lot this iteration, to enable the new functionality use this setting:

"terminal.integrated.experimentalLinkProvider": true

Do some experimental testing with links and the hover, here are some places to start:

  • Different link types work
    • Revealing folders in current window
    • Opening folders in new window (when the folder is outside the workspace)
    • Opening files
    • Searching the workspace for the link (aka "word" links)
  • The new hover text is correct and the link works
  • Holding ctrl/cmd vs not holding when hovering
  • The link "highlight"
  • Alignment of the hover with the editor's hover

Known issues: #96266

@joaomoreno
Copy link
Member

Great job! 👏

@joaomoreno joaomoreno removed their assignment Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants