Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Support tab completion for snippets #9698

Closed
3 tasks done
Tyriar opened this issue Jul 25, 2016 · 7 comments
Closed
3 tasks done

Test: Support tab completion for snippets #9698

Tyriar opened this issue Jul 25, 2016 · 7 comments
Assignees
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 25, 2016

Test for #9579:

There is a new configuration property editor.tabCompletion which defaults to false. When set to true verify that

  • pressing the Tab key when the cursor follows a snippet prefix expands the snippet
  • reason about the name of this setting (tabCompletion) - rationale was that folks know this feature as tab completion
  • make sure things are live: run the Preferences: Snippet to define a new snippet and make sure it works without restart
  • use prefixes with non-word characters like c'l and make sure it works
@Tyriar Tyriar added this to the July 2016 milestone Jul 25, 2016
@egamma egamma mentioned this issue Jul 25, 2016
89 tasks
@gerane
Copy link

gerane commented Jul 25, 2016

@Tyriar Would this work for extension snippets as well? Meaning if you have an extension that creates a new snippet, would it still require a restart for the new extension snippet to be loaded?

@jrieken
Copy link
Member

jrieken commented Jul 25, 2016

yes - in order to activate extension you need to reload the editor

@aeschli
Copy link
Contributor

aeschli commented Jul 26, 2016

I like it, I think we should enable it by default.
The conflict with Emmet is not really a problem given that we have no default snippets for html and the user just needs to pick non conflicting snippet names.

@jrieken
Copy link
Member

jrieken commented Jul 26, 2016

@aeschli Ideas about the name tabCompletion vs snippetTabCompletion?

@joaomoreno
Copy link
Member

I like the current proposal, but I think adding the prefix snippet would benefit it as the feature only revolves around snippets...

@aeschli
Copy link
Contributor

aeschli commented Jul 26, 2016

I'd stick with tabCompletion, it seems to be an established term e.g. in shells. snippetTabCompletion is a strange construct, maybe rather snippetCompletionOnTab or snippetExpansionOnTab

@Tyriar
Copy link
Member Author

Tyriar commented Jul 27, 2016

Closing this off since the test is complete.

@Tyriar Tyriar closed this as completed Jul 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants