Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track "primary" AppsAndFeaturesEntry for better matching #2186

Open
jedieaston opened this issue May 24, 2022 · 1 comment
Open

Track "primary" AppsAndFeaturesEntry for better matching #2186

jedieaston opened this issue May 24, 2022 · 1 comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@jedieaston
Copy link
Contributor

Description of the new feature / enhancement

During the review for #2137, @JohnMcPMS brought up the good point that winget currently doesn't have a way to know which uninstaller to run if a package creates multiple ARP entries. Most applications will have a certain ARP entry that runs an uninstaller that will remove everything the app installed, so that you don't have to go through the list and manually remove them one by one. This value also often is the one that we should probably use for tracking the "true" version number of the package, since it's typically the ARP entry for the main component of the app.

We need a way to tell winget which ARP entry to treat as the main one.

Proposed technical implementation details

There should be an addition to the AppsAndFeaturesEntries portion of the schema that allows the manifest author to denote a single ARP entry as the primary one, so winget knows which uninstaller to run (and when an upgrade is necessary).

  AppsAndFeaturesEntries:
  - DisplayName: Mozilla Maintenance Service
    DisplayVersion: 99.0.1
    Publisher: Mozilla
    ProductCode: MozillaMaintenanceService
  - DisplayName: Mozilla Firefox (x86 nb-NO)
    DisplayVersion: 99.0.1
    Publisher: Mozilla
    ProductCode: Mozilla Firefox 99.0.1 (x86 nb-NO)
    Primary: true
    ```
@jedieaston jedieaston added the Issue-Feature This is a feature request for the Windows Package Manager client. label May 24, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label May 24, 2022
@denelon denelon removed the Needs-Triage Issue need to be triaged label May 24, 2022
@jedieaston
Copy link
Contributor Author

@denelon is this a candidate for #2446?

@denelon denelon added the Area-Manifest This may require a change to the manifest label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

2 participants