Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build on non-English Locale Windows OS #446

Closed
sweetliquid opened this issue Jun 20, 2020 · 0 comments
Closed

Failed to build on non-English Locale Windows OS #446

sweetliquid opened this issue Jun 20, 2020 · 0 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@sweetliquid
Copy link
Contributor

Brief description of your issue

Due to the existence of special characters (such as '…') in the comments of some non-Unicode encoded files, they cannot be compiled in the Windows 10 set "Locale" to Chinese (or other).

Steps to reproduce

Perform the build in the Windows 10 set "Locale" to Chinese (or other).

Expected behavior

Compiled successfully.

Actual behavior

Compilation failed with Compiler Warning C4819

The file contains a character that cannot be represented in the current code page (number).
Save the file in Unicode format to prevent data loss.

Environment

[winget --info]
Windows Package Manager v0.1.41331 预览
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.18363.900
Package: Microsoft.DesktopAppInstaller v1.0.41331.0

Links:
  Privacy Statement: https://aka.ms/winget-privacy
  License agreement: https://aka.ms/winget-license
  3rd Party Notices: https://aka.ms/winget-3rdPartyNotice
  Homepage:          https://aka.ms/winget
@ghost ghost added the Needs-Triage Issue need to be triaged label Jun 20, 2020
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jun 22, 2020
@denelon denelon added this to the Package Manager Backlog milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

2 participants