You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I'm aware that #1920 exists, that covers text which is a fairly significant area that will need a lot of thought.
On the other hand, we've got the progress bar with three existing themes. Here's where I have my questions:
Should this eventually be part of the same configuration effort from Color coding output #1920? It should be easier to implement customizable colors for that than text, since you're generally not going to be worrying about the background color.
In the meantime, would PRs with alternative themes be accepted? My instincts say "probably not, because you'll want to not clog up the codebase with themes and instead make it user configurable," but that's probably a LONG ways off and very low down the priority list.
Proposed technical implementation details
Either one of:
Allow PRs (at least for the time being) with additional progress bar themes.
Start a discussion, either separate or as part of Color coding output #1920, on theming of the progress bar. (I feel it probably should be separate since it's a relatively low bar to entry compared to dealing with various VT background colors..)
Put a hard stop on theming and say "We're not going to actually do anything in this area for a substantial amount of time; either until we've worked out how to proceed, or we decide we're not going to allow any theming outside what we already have."
The text was updated successfully, but these errors were encountered:
Description of the new feature / enhancement
While I'm aware that #1920 exists, that covers text which is a fairly significant area that will need a lot of thought.
On the other hand, we've got the progress bar with three existing themes. Here's where I have my questions:
Proposed technical implementation details
Either one of:
The text was updated successfully, but these errors were encountered: