Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Progress bar color management #4744

Open
Firehawke opened this issue Aug 20, 2024 · 2 comments
Open

RFC: Progress bar color management #4744

Firehawke opened this issue Aug 20, 2024 · 2 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Firehawke
Copy link

Description of the new feature / enhancement

While I'm aware that #1920 exists, that covers text which is a fairly significant area that will need a lot of thought.

On the other hand, we've got the progress bar with three existing themes. Here's where I have my questions:

  1. Should this eventually be part of the same configuration effort from Color coding output #1920? It should be easier to implement customizable colors for that than text, since you're generally not going to be worrying about the background color.
  2. In the meantime, would PRs with alternative themes be accepted? My instincts say "probably not, because you'll want to not clog up the codebase with themes and instead make it user configurable," but that's probably a LONG ways off and very low down the priority list.

Proposed technical implementation details

Either one of:

  1. Allow PRs (at least for the time being) with additional progress bar themes.
  2. Start a discussion, either separate or as part of Color coding output #1920, on theming of the progress bar. (I feel it probably should be separate since it's a relatively low bar to entry compared to dealing with various VT background colors..)
  3. Put a hard stop on theming and say "We're not going to actually do anything in this area for a substantial amount of time; either until we've worked out how to proceed, or we decide we're not going to allow any theming outside what we already have."
@Firehawke Firehawke added the Issue-Feature This is a feature request for the Windows Package Manager client. label Aug 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Aug 20, 2024
@denelon
Copy link
Contributor

denelon commented Aug 27, 2024

I don't know how much those (additional progress bar themes) would add to the size of the package/codebase.

Do you have a few in mind already? I'm happy to chat about options.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Triage Issue need to be triaged label Aug 27, 2024
@denelon
Copy link
Contributor

denelon commented Sep 23, 2024

This just came in...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

2 participants