Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import does not work when some packages names could correspond to multiple packages. #983

Closed
TechWatching opened this issue May 23, 2021 · 4 comments · Fixed by #1473
Closed
Assignees
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@TechWatching
Copy link

Brief description of your issue

winget import fail for some packages because of multiple entries that could match the name of the package.

Steps to reproduce

Create a pacakge.json file with a package (Microsoft.Teams or Microsoft.Office) that has a name that match multple packages.

				{
					"PackageIdentifier": "Microsoft.Teams"
				}
			],
			"SourceDetails" : 
			{
				"Argument" : "https://winget.azureedge.net/cache",
				"Identifier" : "Microsoft.Winget.Source_8wekyb3d8bbwe",
				"Name" : "winget",
				"Type" : "Microsoft.PreIndexed.Package"
			}

Do a winget import package.json

Expected behavior

Installation happen without error.

Actual behavior

Logs can be found in this feedback: https://aka.ms/AAco2lu
image
error is in french but it basically just says Microsoft.Teams name match multiple packages.

Environment

[winget --info]
Windows Package Manager v0.4.11391
Windows: Windows.Desktop v10.0.19042.985
Package: Microsoft.DesktopAppInstaller v1.11.11391.0

Any other software?
@ghost ghost added the Needs-Triage Issue need to be triaged label May 23, 2021
@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged Issue-Feature This is a feature request for the Windows Package Manager client. labels May 24, 2021
@denelon
Copy link
Contributor

denelon commented May 25, 2021

We haven't reproduced this issue yet. We're going to look into this further, and may add logging and see if we can reproduce. If not, we will likely ask for you to submit Feedback https://aka.ms/winget-feedback.

@TechWatching
Copy link
Author

As indicated in the issue description, you can already find my feedback with the logs here.
image
Tell me if you need more info.

@denelon
Copy link
Contributor

denelon commented May 25, 2021

@TechWatching I was mentioning that we may need to add "more" logging (in a newer version) and get feedback after that point. Sorry for the confusion.

@Nollknolle
Copy link

Same issue

@ghost ghost added the In-PR Issue related to a PR label Sep 16, 2021
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants