Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to modify an existing manifest #111

Closed
ryfu-msft opened this issue Jul 16, 2021 · 0 comments · Fixed by #171
Closed

Add functionality to modify an existing manifest #111

ryfu-msft opened this issue Jul 16, 2021 · 0 comments · Fixed by #171
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed
Milestone

Comments

@ryfu-msft
Copy link
Contributor

As of right now, we only have the new command to generate new manifests and the update command to update installer urls, version, and hash. There is a need for a modify command that pulls down an existing manifest and allows a user to make changes to any field they want to edit.

This would address issues like #75 by allowing users to replace installers and their related fields. We currently don't support replacing existing installers with new ones in order to preserve updating multiple installers and avoid accidentally replacing the wrong installer.

The modify command flow would look something like this:

wingetcreate modify <Package Identifier> -v <Version>

  • Pulls down the manifests for the specified package and the specified version (if no version is specified, latest manifest is pulled down)
  • Prompts would show for each field, with some form of selection logic to allow users to edit by manifest, installer node, field, etc.
  • Saves newly modified manifests locally and also prompts the user if they would like to submit to the Winget-Pkgs repository.
@ryfu-msft ryfu-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 16, 2021
@ryfu-msft ryfu-msft added this to the v.Next - `winget create` milestone Jul 16, 2021
@ghost ghost added the Needs-Triage label Jul 16, 2021
@ghost ghost added the In-PR label Sep 16, 2021
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Sep 22, 2021
@denelon denelon modified the milestones: v.Next-Create, v1.0-Create Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants