Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget Create Error #234

Closed
gdiObjects opened this issue Mar 3, 2022 · 10 comments · Fixed by #235
Closed

Winget Create Error #234

gdiObjects opened this issue Mar 3, 2022 · 10 comments · Fixed by #235

Comments

@gdiObjects
Copy link

The following error message appeared when submitting an update to an existing package (gdiObjects.Perspective)

Manifest saved to C:\WINDOWS\system32\manifests\g\gdiObjects\Perspective\3.1.2203.2

Manifest validation succeeded: True

Submitting pull request for manifest...

Octokit.NotFoundException: Not Found
at Octokit.Connection.HandleErrors(IResponse response) in /home/runner/work/octokit.net/octokit.net/Octokit/Http/Connection.cs:line 700
at Octokit.Connection.RunRequest(IRequest request, CancellationToken cancellationToken) in /home/runner/work/octokit.net/octokit.net/Octokit/Http/Connection.cs:line 683
at Octokit.Connection.Run[T](IRequest request, CancellationToken cancellationToken) in /home/runner/work/octokit.net/octokit.net/Octokit/Http/Connection.cs:line 668
at Octokit.ApiConnection.Post[T](Uri uri, Object data, String accepts, String contentType, CancellationToken cancellationToken) in /home/runner/work/octokit.net/octokit.net/Octokit/Http/ApiConnection.cs:line 293
at Microsoft.WingetCreateCore.Common.GitHub.<>c__DisplayClass19_0.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Polly.AsyncPolicy.<>c__DisplayClass40_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at Polly.Retry.AsyncRetryEngine.ImplementationAsync[TResult](Func3 action, Context context, CancellationToken cancellationToken, ExceptionPredicates shouldRetryExceptionPredicates, ResultPredicates1 shouldRetryResultPredicates, Func5 onRetryAsync, Int32 permittedRetryCount, IEnumerable1 sleepDurationsEnumerable, Func4 sleepDurationProvider, Boolean continueOnCapturedContext) at Polly.AsyncPolicy.ExecuteAsync(Func3 action, Context context, CancellationToken cancellationToken, Boolean continueOnCapturedContext)
at Microsoft.WingetCreateCore.Common.GitHub.SubmitPRAsync(String packageId, String version, Dictionary2 contents, Boolean submitToFork) at Microsoft.WingetCreateCore.Common.GitHub.SubmitPRAsync(String packageId, String version, Dictionary2 contents, Boolean submitToFork)
at Microsoft.WingetCreateCLI.Commands.BaseCommand.GitHubSubmitManifests(Manifests manifests)
at Microsoft.WingetCreateCLI.Commands.UpdateCommand.ExecuteManifestUpdate(List`1 latestManifestContent, CommandExecutedEvent commandEvent)
at Microsoft.WingetCreateCLI.Commands.UpdateCommand.Execute()
at Microsoft.WingetCreateCLI.Program.Main(String[] args)
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/git#create-a-reference"}

@ghost ghost added the Needs-Triage label Mar 3, 2022
@denelon denelon transferred this issue from microsoft/winget-pkgs Mar 3, 2022
@JanDeDobbeleer
Copy link
Contributor

@gdiObjects in my case, I had too many branches on my winget-pkgs fork (254). As soon as I removed a few, everything started working again.

@gdiObjects
Copy link
Author

@gdiObjects in my case, I had too many branches on my winget-pkgs fork (254). As soon as I removed a few, everything started working again.

How do I remove branches from a winget-pkgs fork? (thanks)

@JanDeDobbeleer
Copy link
Contributor

JanDeDobbeleer commented Mar 3, 2022

@gdiObjects you can use the GitHub UI to display all branches and there's a trash icon next to every one.

@gdiObjects
Copy link
Author

@gdiObjects you can use the GitHub UI to display all branches and there's a trash icon next to every one.

Thanks for the link! There are only around 8 forks, so I'm not sure that's the problem.

@Megasware128
Copy link

I have the same error but I just have 1 branch still open

@LeonarddeR
Copy link

I have 18 branches, same error indeed.

@ryfu-msft ryfu-msft self-assigned this Mar 7, 2022
@ryfu-msft
Copy link
Contributor

So I was able to repro the issue, and I believe the issue was that my forked branch was behind the upstream reference "microsoft:master". Once I fetched the new commits and merged it into the fork's master branch, I was able to submit successfully. Could you try that and verify that it resolved the issue?

@Megasware128
Copy link

@ryfu-msft Yes! Updating master on my fork fixed my issue

@r12f
Copy link

r12f commented Mar 15, 2022

I am using the update command with --submit directly, and I am also getting this exact same error. The version I am using is v0.5.0.1.

.\wingetcreate.exe update r12f.Rnp -u https://github.com/r12f/rnp/releases/download/0.1.143.main/rnp.0.1.143.main.windows.x86.msix https://github.com/r12f/rnp/releases/download/0.1.143.main/rnp.0.1.143.main.windows.x64.msixhttps://github.com/r12f/rnp/releases/download/0.1.143.main/rnp.0.1.143.main.windows.arm64.msix -v 0.1.143.0 -t <PST> --submit

@slonopotamus
Copy link

slonopotamus commented Mar 20, 2022

I'm observing this issue even if I manually fetch changes from upstream to my fork of winget-pkgs repo before running winget-create =/

UPD: This is possibly caused by the fact that I was trying to use token without public_repo scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants