ZIP Packages update autonomously but not in interactive mode

[mdanish-kh]

Brief description of your issue

Interactive update uses a call to ParsePackageAndUpdateInstallerNode() to Parse the InstallerType of an installer.

winget-create/src/WingetCreateCLI/Commands/UpdateCommand.cs

Line 724 in 5ec4ad6

else if (!PackageParser.ParsePackageAndUpdateInstallerNode(installer, packageFile, url))

This uses the Vestris.ResourceLib to parse the installer and retrieve its InstallerType. For zip installers in interactive updates, this seem to throw a Win32 Exception and interactive update returns Failed to parse the package from [<InstallerUrl>] at:

winget-create/src/WingetCreateCore/Common/PackageParser.cs

Lines 703 to 710 in 5ec4ad6

	rc.LoadFrom(path);
	string installerType = rc.Manifest.DocumentElement
	.GetElementsByTagName("description")
	.Cast<XmlNode>()
	.FirstOrDefault()?
	.InnerText?
	.Split(' ').First()
	.ToLowerInvariant();

which is called from:

winget-create/src/WingetCreateCore/Common/PackageParser.cs

Lines 283 to 285 in 5ec4ad6

	bool parseResult = ParseExeInstallerType(path, installer, newInstallers) ||
	ParseMsix(path, installer, null, newInstallers) ||
	ParseMsi(path, installer, null, newInstallers);

This is because the path passed to the ResourceLib is path to the ZIP archive ending in .zip and not the actual installer present in the archive.

Steps to reproduce

Unattended update: (Dummy version used to simulate update)

1. Nested nullsoft

wingetcreate update Guru3D.Afterburner -v 18.0 --urls "https://download-eu2.guru3d.com/afterburner/[Guru3D.com]-MSIAfterburnerSetup465.zip"

2. Nested MSI

wingetcreate update aluxnimm.outlookcaldavsynchronizer -v 18.0 --urls "https://github.com/aluxnimm/outlookcaldavsynchronizer/releases/download/v4.3.0/OutlookCalDavSynchronizer-4.3.0.zip"

3. Nested Portable

wingetcreate update Hugo.Hugo -v 18.0 --urls "https://github.com/gohugoio/hugo/releases/download/v0.112.7/hugo_0.112.7_windows-amd64.zip" "https://github.com/gohugoio/hugo/releases/download/v0.112.7/hugo_0.112.7_windows-arm64.zip"

4. Nested portable

wingetcreate update Istio.Istio -v 18.0 --urls "https://github.com/istio/istio/releases/download/1.17.3/istioctl-1.17.3-win.zip"

Notice they all succeed in autonomous update. Now try the same packages in interactive update i.e.,

wingetcreate update Guru3D.Afterburner -v 18.0 -i
wingetcreate update aluxnimm.outlookcaldavsynchronizer -v 18.0 -i
wingetcreate update Hugo.Hugo -v 18.0 -i
wingetcreate update Istio.Istio -v 18.0 -i

Expected behavior

Interactive update should succeed like the autonomous ones

Actual behavior

Interactive updates gives Failed to parse the package from [<InstallerUrl>] after downloading the package from URL.

Environment

Windows Package Manager Manifest Creator v1.2.7.0