Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command shouldn't submit PR if there's no changes #87

Closed
palenshus opened this issue Jun 16, 2021 · 0 comments · Fixed by #100
Closed

Update command shouldn't submit PR if there's no changes #87

palenshus opened this issue Jun 16, 2021 · 0 comments · Fixed by #100

Comments

@palenshus
Copy link
Contributor

Brief description of your issue

When wingetcreate update is run with just a packageId, it'll fetch the package at the current URL, hash it, and submit an update PR. This makes sense if the URL is a vanity URL and the version is "latest", but not in other cases. For example, see this PR microsoft/winget-pkgs#17720 (comment)

Steps to reproduce

wingetcreate update GitHub.cli -s

Expected behavior

Aborts after determining that there's no substantial changes to be made

Actual behavior

Downloads package at current URL, hashes it (resulting in the same hash), and submits a PR with no real changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants