Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full ESM Support #584

Closed
2 tasks
willfarrell opened this issue Dec 16, 2020 · 2 comments
Closed
2 tasks

Full ESM Support #584

willfarrell opened this issue Dec 16, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@willfarrell
Copy link
Member

willfarrell commented Dec 16, 2020

We really want to have Middy support ESM, however we're blocked by a few items.

  • Lambda with ESM cannot access node_modules pre-bundled in the runtime or shared in a lambda layer has made us stop and rethink. This isn't documented anywhere that I know of 😔. I've reported this regression to AWS Support and was told to use v3 of the SDK instead.

You can test this by using:

// index.mjs
import AWS from 'aws-sdk'
export const handler = () => AWS.VERSION
@willfarrell willfarrell added this to the v2.0.0 milestone Dec 16, 2020
@willfarrell willfarrell self-assigned this Dec 16, 2020
@willfarrell willfarrell mentioned this issue Dec 16, 2020
63 tasks
@willfarrell
Copy link
Member Author

complete in v2 alpha

@willfarrell willfarrell reopened this Jan 3, 2021
@willfarrell willfarrell modified the milestones: v2.0.0, v3.0.0 Jan 3, 2021
@willfarrell
Copy link
Member Author

willfarrell commented Jan 3, 2021

Rolled back, AWS SDK v3 is not ready for production use on Lambda. Reopened due to #585 (comment)

@willfarrell willfarrell mentioned this issue Mar 14, 2021
26 tasks
@willfarrell willfarrell mentioned this issue Jan 5, 2022
34 tasks
@willfarrell willfarrell modified the milestones: v3.0.0, v4.0.0 Jan 5, 2022
@willfarrell willfarrell added the blocked Blocked Externally label Jan 16, 2022
@willfarrell willfarrell changed the title Update to use AWS SDK v3 ESM & AWS SDK v3 Support Feb 15, 2022
@willfarrell willfarrell pinned this issue Feb 15, 2022
@willfarrell willfarrell modified the milestones: v4.0.0, v3.0.0 Feb 15, 2022
@willfarrell willfarrell changed the title ESM & AWS SDK v3 Support ESM & AWS SDK v3 Support [Help Needed] Feb 15, 2022
@willfarrell willfarrell unpinned this issue May 13, 2022
@willfarrell willfarrell modified the milestones: v3.0.0, v4.0.0 May 13, 2022
@willfarrell willfarrell changed the title ESM & AWS SDK v3 Support [Help Needed] Full ESM Support Oct 11, 2022
@willfarrell willfarrell modified the milestones: v4, v5 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant