Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle type definitions with packages instead of definitely-typed #591

Closed
baileytincher opened this issue Jan 3, 2021 · 1 comment
Closed

Bundle type definitions with packages instead of definitely-typed #591

baileytincher opened this issue Jan 3, 2021 · 1 comment

Comments

@baileytincher
Copy link
Contributor

A mild nuance, but since the type definitions for middy are maintained by middy it is recommended to bundle with source https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

Hopefully this could further simplify deployments
@willfarrell
Copy link
Member

I have no plans on removing the type definitions from the packages. Are you referring to @types/middy comment? If bundled with the code is recommended then we'll keep doing that.

@willfarrell willfarrell mentioned this issue Jan 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willfarrell @baileytincher