Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper-progress-circular doesn't rotate anymore #173

Closed
pomm0 opened this issue Sep 10, 2015 · 8 comments
Closed

paper-progress-circular doesn't rotate anymore #173

pomm0 opened this issue Sep 10, 2015 · 8 comments

Comments

@pomm0
Copy link
Contributor

pomm0 commented Sep 10, 2015

Hey,

i've seen that the paper-progress-circular is not rotating anymore. Same on your demosite http://miguelcobain.github.io/ember-paper/#/progress-circular.

It's working on the Angular-Material demosite https://material.angularjs.org/latest/#/demo/material.components.progressCircular

Not sure what happend that it's not working anymore.

Testet on Chrome Linux Version 45.0.2454.85 (64-bit) and IE 11 Win 7

@cah-danmonroe
Copy link
Contributor

Demo is working for me on my MacBook - Chrome Version 45.0.2454.85 (64-bit)

@miguelcobain
Copy link
Collaborator

Working here too! Chrome 45.0.2454.85 64-bit, Linux.

@pomm0
Copy link
Contributor Author

pomm0 commented Sep 10, 2015

I can't test it on OSX. But i tested it on a iPhone and in Win 7 Chrome with Version 45.0.2454.85 m and it does not work. It does the animation of shrinking and growing but it doesn't rotate.

@pomm0
Copy link
Contributor Author

pomm0 commented Sep 10, 2015

On Win 7 Chrome Version 45.0.2454.85 m and everywhere else i tried its doing like that:

https://vid.me/VfIr

@miguelcobain
Copy link
Collaborator

Ah, rotating!

Yes, I can see the issue here as well!

@lone-cloud
Copy link

The working demo has been moved to: https://material.angularjs.org/latest/demo/progressCircular

This has been a big pet peeve for me. Has anyone looked into how it broke?

Edit: I briefly looked into this issue now and the issue is the inline style on of '-webkit-transform: scale(1)' on .md-spinner-wrapper ( the demo from the material docs above doesn't have it either ). Removing this inline style gets the spinner, spinning properly again with no visible regression ( tested only in Chrome v45... no clue about safari ).

@mike1o1
Copy link
Contributor

mike1o1 commented Oct 14, 2015

I'll look this week and should be able to get it fixed.

On Wed, Oct 14, 2015 at 11:29 AM, Egor Philippov [email protected]
wrote:

The working demo has been moved to:
https://material.angularjs.org/latest/demo/progressCircular

This has been a big pet peeve for me. Has anyone looked into how it broke?


Reply to this email directly or view it on GitHub
#173 (comment)
.

@lone-cloud
Copy link

Hopefully this saves you some time, but the circleStyle computed property seems to be the culprit responsible for this breaking inline style.
I tried to patch around it using:
md-progress-circular[md-mode=indeterminate] .md-spinner-wrapper {
transform: none !important;
}
and this does make the spinner spin correctly for some browsers.
Tested and works for - IE 11, Chrome 45. Tested and broken in FF 41. Basically the 'transform' property of .md-spinner-wrapper needs to be computed to 'matrix(...)' for the spinning to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants