-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace all instances of attribute based flex layout and replace with class based ones #507
Comments
👋 I might take a stab at this this week. |
+1 I'm currently excluding the attribute css file by hand (by completely copying the |
Alas: I’ve gotten hammered with some surprises this month. If someone else wants this for t-shirt time… please take it.
|
I noticed in the Angular docs that it says:
Thoughts? |
@jamesdixon angular has some capabilities that ember does not. Those directives are translated to classes at runtime (or compile time?). In ember they would remain in the DOM, with performance and flexibility concerns. I think the general conclusion was that classes are a better fit for ember. |
Fair enough! Just wanted to mention it. Thanks, @joukevandermaas! |
Fixed (see #507 (comment) for details) |
Previously we used Angular Material's attribute based flex layout like:
However, sometimes we need these attributes in components, so we created a FlexMixin that has those attributeBindings, e.g
{{paper-component flex="20"}}
. However, the current scenario is suboptimal:layout
. That property name is already taken in Ember components.Angular Material converts attributes to classes under the hood with attribute directives. We think the classes AM uses under the hood make a perfect public api. Ember components and normal elements support
class
attribute by default.So, the above example converts to:
TODO:
The text was updated successfully, but these errors were encountered: