Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation: paper-progress-linear #135

Conversation

peec
Copy link
Contributor

@peec peec commented Jul 19, 2015

This PR fixes deprecation notice for progress-linear, tested with (1.13.3):

DEPRECATION: A property of <dummy@view:-outlet::ember279> was modified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation.

…dified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation.
@miguelcobain
Copy link
Collaborator

I don't really understand the point of this md-ready class.

We're adding it on the didInsertElement hook. Isn't that the same as including that class directly in the template?

@peec
Copy link
Contributor Author

peec commented Jul 19, 2015

@miguelcobain Yeah, I just tried without the whole didInsertElement and just use md-ready directly in the template. Updated the PR with working changes. I think it's only needed because how angular renders the template.

miguelcobain added a commit that referenced this pull request Jul 19, 2015
…notice

Fix deprecation: paper-progress-linear
@miguelcobain miguelcobain merged commit b019be1 into adopted-ember-addons:master Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants