Add closeOnClick to paper-sidenav
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to adopted-ember-addons#204 `closeOnClick` defaults to `true`, making this option backwards compatible.
|
Thanks for taking the time to implement! Would you mind adding a changelog entry? |
|
All set @mike1o1. How would I update the docs, is that in the gh-pages branch or is that the built version from the dummy app? |
|
Docs are in the dummy app. Thanks! |
|
@mike1o1 all fixed, see the screenshot above. |
Also fix sidenav example and fix scrolling
miguelcobain
added a commit
that referenced
this pull request
Jan 4, 2016
Add `closeOnClick` to paper-sidenav
|
@knownasilya Perfect PR. Thanks. |
|
No, thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #204 (fixes #204)
closeOnClickdefaults totrue, making this option backwards compatible.