allow touch devices to interact with autocomplete #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clarify why paper-select doesn't need this? |
|
@miguelcobain Because there is no need to focus on any of the children of the trigger in the case of paper-select because there is no text input underneath the trigger that we're trying to access. In autocomplete we need to focus on the input in order to type, so it's problematic that the event is not allowed to go past the trigger container. |
|
I see. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, touch devices are unable to focus on the input in paper-autocomplete because ember-basic-dropdown does a preventDefault on the touch event that prevents the focus event from being called on the input. This corrects that issue.