Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/paste support #39

Closed
dehydr8 opened this issue Nov 6, 2018 · 4 comments
Closed

Copy/paste support #39

dehydr8 opened this issue Nov 6, 2018 · 4 comments

Comments

@dehydr8
Copy link
Contributor

dehydr8 commented Nov 6, 2018

The packaged electron application doesn't support copy/paste and other editing functions because the menu items and bindings need to be explicitly added. Reference: electron/electron#2591

The menu items and bindings need to be added in app/layout/shell.js to enable support for the said functions.

@dehydr8 dehydr8 mentioned this issue Nov 6, 2018
@mike-goodwin
Copy link
Owner

mike-goodwin commented Jun 14, 2019

As far as I can tell these editing functions do work via keyboard shortcuts (Ctrl-C etc.). Is this request to add a context (right-click) menu with the editing operations. I saw from your PR #40 that you were adding an edit submenu to the top menu bar. This doesn't seem to work because if you select the menu option, the edit box you were in loses focus. Which behaviour are you aiming for?

@dehydr8
Copy link
Contributor Author

dehydr8 commented Jun 16, 2019

It works normally when we start the application using npm run start (triggers electron .) because it starts the app with electron's default menu items. But since we don't have these menu items in the packages application, Cmd+C and other keyboard shortcuts (on a mac) don't work.

@mike-goodwin
Copy link
Owner

So it fails on a Mac? OK, I should be getting a Mac to test on soon, as soon as I do I will get this addressed. Thanks for your contribution!

@mike-goodwin
Copy link
Owner

Merged in Pr #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants