Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deviantArt] Add support for Scraps-galleries #168

Closed
a-washing-machine opened this issue Feb 20, 2019 · 7 comments
Closed

[deviantArt] Add support for Scraps-galleries #168

a-washing-machine opened this issue Feb 20, 2019 · 7 comments

Comments

@a-washing-machine
Copy link

I must say I am impressed with the versatility of the deviantArt downloader here!

It supports groups, folders, favorites, even journals and text-submissions.

...But it doesn't support scraps?


gallery-dl.exe https://www.deviantart.com/cryptid-creations/gallery/?catpath=scraps
[gallery-dl][error] No suitable extractor found for 'https://www.deviantart.com/cryptid-creations/gallery/?catpath=scraps'


Even the legacy URL-format doesn't work. ( https://cryptid-creations.deviantart.com/gallery/?catpath=scraps )

Internally, scraps work the same as the regular gallery, so I'm a bit confused why that isn't supported.

Or did I do something wrong?

It actually is supported and I just need to modify the link in some way??

@mikf
Copy link
Owner

mikf commented Feb 20, 2019

No, you didn't do anything wrong.

gallery-dl uses the OAuth2 API for basically everything, but I still haven't figured out how to get it to produce a list of all scraps.

@a-washing-machine
Copy link
Author

Huh. Okay, thanks for the info.

@Hrxn
Copy link
Contributor

Hrxn commented Feb 20, 2019

Not sure, but isn't scraps something like drafts, basically? i.e. "unreleased" gallery items?
Maybe it's supposed to be this way?

@a-washing-machine
Copy link
Author

a-washing-machine commented Feb 23, 2019

No, "scraps" are not "drafts". I can see where the confusion comes from.

Stash is where you upload your non-public drafts (or abuse it as a generic image hosting service).

Scraps are public submissions the artist has deemed to be of lower quality than their usual work, but still show up in your feed (though you can turn them on/off on an artist-by-artist basis).

The thing is, quality is relative to the artist, and there are a lot of "scraps" I wouldn't want to miss. ;-)

@mikf mikf closed this as completed in 13e0f2a Mar 1, 2019
@a-washing-machine
Copy link
Author

Oh! Thanks! :D

After you said you hadn't had any luck figuring out the problem before, I didn't actually expect this to be solved!

I was honestly about to code an HTML-scrapper that would've parsed the individual gallery pages for artwork-page links (i.e. get all links containing "deviantart.com" and "/art/"), to input them into gallery-dl, and get the scraps that way.

But your solution is better. ^_^

@a-washing-machine
Copy link
Author

Now I hate to be "that guy", but I have another possible feature request... ^_^;;

I did try to look into the problem myself... but, well. Uhm. I have zero python experience. ._.;;

@kargaroc
Copy link

This should probably be automatic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants