Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reddit] [yt-dlp] YoutubeDL.parse_outtmpl deprecation results in video download failure. #2692

Closed
Silent-Soldier opened this issue Jun 19, 2022 · 0 comments

Comments

@Silent-Soldier
Copy link

First noticed the error on Reddit with "videos": true set in config file. Verbose output:

gallery-dl -v "https://www.reddit.com/r/VampireSurvivors/comments/vfj7oy/clerici_4_golden_egg_run_in_1_minute_or_less/"
2022-06-18 22:26:16 [gallery-dl][debug] Version 1.22.2-dev
2022-06-18 22:26:16 [gallery-dl][debug] Python 3.10.5 - Windows-10-10.0.19044-SP0
2022-06-18 22:26:16 [gallery-dl][debug] requests 2.28.0 - urllib3 1.26.9
2022-06-18 22:26:16 [gallery-dl][debug] Starting DownloadJob for 'https://www.reddit.com/r/VampireSurvivors/comments/vfj7oy/clerici_4_golden_egg_run_in_1_minute_or_less/'
2022-06-18 22:26:17 [reddit][debug] Using RedditSubmissionExtractor for 'https://www.reddit.com/r/VampireSurvivors/comments/vfj7oy/clerici_4_golden_egg_run_in_1_minute_or_less/'
2022-06-18 22:26:17 [urllib3.connectionpool][debug] Starting new HTTPS connection (1): oauth.reddit.com:443
2022-06-18 22:26:17 [urllib3.connectionpool][debug] https://oauth.reddit.com:443 "GET /comments/vfj7oy/.json?limit=350&raw_json=1 HTTP/1.1" 200 3212
2022-06-18 22:26:17 [reddit][debug] Using download archive './gallery-dl/.archives/reddit.sqlite3'
2022-06-18 22:26:17 [postprocessor.metadata][debug] Using download archive './gallery-dl/.archives/reddit-metadata.sqlite3'
2022-06-18 22:26:17 [postprocessor.ugoira][debug] using mkvmerge demuxer
2022-06-18 22:26:17 [reddit][debug] Active postprocessor modules: [ClassifyPP, MetadataPP, MtimePP, UgoiraPP]

Tried direct download via gallery-dl of URI and the error messages point to [cleanup] Deprecate YoutubeDL.parse_outtmpl as the likely culprit. Verbose output:

gallery-dl -v "https://www.youtube.com/watch?v=b4uzPTXOtRs&t=2s&ab_channel=Fermitkrog"
2022-06-18 22:26:42 [gallery-dl][debug] Version 1.22.2-dev
2022-06-18 22:26:42 [gallery-dl][debug] Python 3.10.5 - Windows-10-10.0.19044-SP0
2022-06-18 22:26:42 [gallery-dl][debug] requests 2.28.0 - urllib3 1.26.9
2022-06-18 22:26:42 [gallery-dl][debug] Starting DownloadJob for 'https://www.youtube.com/watch?v=b4uzPTXOtRs&t=2s&ab_channel=Fermitkrog'
2022-06-18 22:26:44 [ytdl][debug] Using YoutubeDLExtractor for 'https://www.youtube.com/watch?v=b4uzPTXOtRs&t=2s&ab_channel=Fermitkrog'
2022-06-18 22:26:44 [ytdl][debug] Using <module 'yt_dlp' from '*****\\Python\\Python310\\site-packages\\yt_dlp\\__init__.py'>
2022-06-18 22:26:44 [ytdl][debug] [youtube] b4uzPTXOtRs: Downloading webpage
2022-06-18 22:26:44 [ytdl][debug] [youtube] b4uzPTXOtRs: Downloading android player API JSON
2022-06-18 22:26:44 [ytdl][debug] [youtube] b4uzPTXOtRs: Downloading player f05de49d
2022-06-18 22:26:45 [ytdl][debug] [youtube] b4uzPTXOtRs: Downloading MPD manifest
2022-06-18 22:26:45 [ytdl][debug] [youtube] b4uzPTXOtRs: Downloading MPD manifest
2022-06-18 22:26:46 [ytdl][debug] [info] Testing format 303
2022-06-18 22:26:46 [ytdl][debug] [dashsegments] Total fragments: 1
2022-06-18 22:26:46 [ytdl][debug] [download] Destination: *****\tmps9w_tz8r.tmp
2022-06-18 22:26:52 [ytdl][debug] [download] Download completed
2022-06-18 22:26:52 [ytdl][debug] [info] Testing format 251
2022-06-18 22:26:52 [ytdl][debug] [download] Destination: *****\tmpsebivsng.tmp
2022-06-18 22:26:52 [ytdl][debug] [download] Download completed
2022-06-18 22:26:52 [ytdl][debug] Using download archive './gallery-dl/.archives/ytdl.sqlite3'
2022-06-18 22:26:52 [postprocessor.metadata][debug] Using download archive './gallery-dl/.archives/ytdl-metadata.sqlite3'
2022-06-18 22:26:52 [postprocessor.ugoira][debug] using mkvmerge demuxer
2022-06-18 22:26:52 [ytdl][debug] Active postprocessor modules: [MetadataPP, MtimePP, UgoiraPP]
  .\gallery-dl\ytdl\Youtube\Fermitkrog_UCEA5BpBfVvEHcjHmY2ocV8g\Vampire Survivor Clerici Easy Egg Farm-b4uzPTXOtRs.mkv2022-06-18 22:26:52 [downloader.ytdl][debug] Traceback
Traceback (most recent call last):
  File "*****\Python\Python310\site-packages\gallery_dl\downloader\ytdl.py", line 113, in _download_video
    ytdl_instance.process_info(info_dict)
  File "*****\Python\Python310\site-packages\yt_dlp\YoutubeDL.py", line 2845, in process_info
    info_dict['_filename'] = full_filename = self.prepare_filename(info_dict, warn=True)
  File "*****\Python\Python310\site-packages\yt_dlp\YoutubeDL.py", line 1281, in prepare_filename
    filename = self._prepare_filename(info_dict, tmpl_type=dir_type, outtmpl=outtmpl)
  File "*****\Python\Python310\site-packages\yt_dlp\YoutubeDL.py", line 1249, in _prepare_filename
    outtmpl = self.params['outtmpl'].get(tmpl_type or 'default', self.params['outtmpl']['default'])
AttributeError: 'str' object has no attribute 'get'
2022-06-18 22:26:52 [download][error] Failed to download Vampire Survivor Clerici Easy Egg Farm-b4uzPTXOtRs.mkv
@mikf mikf closed this as completed in 1aae9f2 Jun 20, 2022
@mikf mikf added the bug label Jun 20, 2022
@mikf mikf added the ytdl label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants