Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twitter] conversations option not being respected #2710

Closed
ponchojohn1234 opened this issue Jun 27, 2022 · 6 comments
Closed

[Twitter] conversations option not being respected #2710

ponchojohn1234 opened this issue Jun 27, 2022 · 6 comments

Comments

@ponchojohn1234
Copy link

even with the option "conversations" set to false, threads where a user has participated still get download even when it shouldn't
for example with this url: https://twitter.com/Anon2000000

this image get downloaded
https://twitter.com/kwawakari/status/1500484712669888521
which shouldn't happen since it wasn't posted by the original user

@ponchojohn1234 ponchojohn1234 changed the title twitter conversations option not being respected [Twitter] conversations option not being respected Jun 27, 2022
@nisehime
Copy link

"conversations" option does not affect timeline extractor. You'd probably want to upgrade to v1.22.2 and set replies option to self to solve your issue.

@ponchojohn1234
Copy link
Author

actually im using 1.22.2, this issue is about a behaviour change that happened in this version since in 1.22.1 it works fine, also this isn't a solution since my problem is that it's downloading entire conversations when it shouldn't, i do want replies downloaded even if the user being replied to isn't the same user that replied

@nisehime
Copy link

i do want replies downloaded even if the user being replied to isn't the same user that replied

This is what replies: "self" does on 1.22.2. Also, on 1.22.1 it was downloading only normal timeline (if you had retweets: true), not the replies, which means you were missing tweets in fact.

@ponchojohn1234
Copy link
Author

if that's the case someone forgot to update the docs lol, let me test some stuff and if i fix it i'll close the issue

@nisehime
Copy link

Unfortunately, even with replies: "self" it will still download quoted tweets from replies, though. That's a bug.

@ponchojohn1234
Copy link
Author

yeah it seems you are correct, some should update the docs tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants