Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hitomi.la changed it's system #321

Closed
annn1885 opened this issue Jun 27, 2019 · 5 comments
Closed

hitomi.la changed it's system #321

annn1885 opened this issue Jun 27, 2019 · 5 comments
Labels

Comments

@annn1885
Copy link

Describe the issue
Hitomi.la now uses this sorta preview system, where the similar images are bundled together. Say that there are 110 images spread out in 12 groups. gallery-dl will download just the previews of the groups, that is 12 images and not 110.
In a way it makes the previews a lot nicer but it breaks the script.

Details

$ gallery-dl -v
[gallery-dl][debug] Version 1.8.7-dev
[gallery-dl][debug] Python 3.6.8 - Linux-4.15.0-52-generic
[gallery-dl][debug] requests 2.22.0 - urllib3 1.25.3
@mikf
Copy link
Owner

mikf commented Jun 27, 2019

I've been testing a couple of galleries from Hitomi's front page and everything looks and works the way it is supposed to. It downloads individual doujinshi pages and for artist cgs with > 600 images it gets all of them.

Could you share the link to said gallery or at least its gallery ID so I can take a look at it and see what is going on?

@annn1885
Copy link
Author

annn1885 commented Jun 27, 2019

I did find a good example for testing. gdl only downloads 12 images, in reality there are 210 images.
The id is 733697.
Edit: as you can image groups have a .badge that tells how many images there are. Considering this is from 2014, I suspect either is a new system implemented by the uploader later, or it has been automatically done by the site.

@annn1885 annn1885 reopened this Jun 27, 2019
@annn1885
Copy link
Author

Sorry for the close there, my mistake.
I was trying to think about a better title to represent this issue for others in the future... and I pressed the wrong button 😓

@mikf mikf closed this as completed in 0551024 Jun 27, 2019
@mikf
Copy link
Owner

mikf commented Jun 27, 2019

Should be fixed now. Apparently this new "system" gets only used in Game CG galleries.

@mikf mikf added the bug label Jun 27, 2019
@annn1885
Copy link
Author

@mikf it indeed works. Thank you for the unbelievable quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants