Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Archive should treat paths the same as download paths #3361

Open
diamondsw opened this issue Dec 5, 2022 · 2 comments
Open

Comments

@diamondsw
Copy link

I've now been bitten by this on multiple occasions - the archive path is not treated the same as other paths. It does not consider the base-directory (#2398), it does not support variable substitution consistently (also #2398), and it does not always handle path restriction (#3359). My use case is keeping the archive located with the downloaded files, as I may use different hosts to download to a common location (i.e. stored on a NAS).

@Hrxn
Copy link
Contributor

Hrxn commented Dec 6, 2022

Okay, how do you end up in a situation where you would need to rely on "path-restrict" for the archive path setting?
Who or what is writing your config file?

@diamondsw
Copy link
Author

If something hits the filesystem, then it needs to be path restricted. The bug report above includes an example of this not happening; i.e. a variable has a "/" in it, which causes the archive to end up in the wrong place because it doesn't sanitize the path properly.

This is basic input sanitization. If you're touching the filesystem, you must sanitize (or "path restrict" in your parlance) for filesystem-valid characters. Anything else is simply incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants