Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags not supported in extractor.*.archive #985

Closed
kattjevfel opened this issue Sep 9, 2020 · 4 comments
Closed

tags not supported in extractor.*.archive #985

kattjevfel opened this issue Sep 9, 2020 · 4 comments

Comments

@kattjevfel
Copy link
Contributor

I tried setting "archive": "/mnt/jupiter/Temp/gallery-dl/archives/{category}.sqlite3", but I ended up with a file called literally {category}.sqlite3. Am I doing something wrong or is this simply not supported?

@mikf
Copy link
Owner

mikf commented Sep 10, 2020

Not supported, the archive setting only accepts plain paths.
I can see how using {category} would be really helpful here, but I'd rather not add the ability to use general tags in paths.

@kattjevfel
Copy link
Contributor Author

Why not? Isn't that being done elsewhere already?

@mikf
Copy link
Owner

mikf commented Sep 10, 2020

No, it is only supported for the directory setting with its "weird" syntax (["…", "…"]) and nowhere else, because external inputs in a local path are generally a bad idea.

I guess it wouldn't hurt to have a bit more convenience in some places,
but then there would also be the inconsistency of some paths supporting it, and some not.
(e.g. archive <-> cache.file, logfile)

@kattjevfel
Copy link
Contributor Author

Couldn't the inconsistencies be documented (and why it'd be a bad idea) and have the rest work? I don't know the exact code and python is a bit of dark magic to me, maybe it'd be a very messy implementation and in that case I understand not wanting to implement it.

Either way I suppose adding archive to each and every entry isn't the end of the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants