Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@deb0ch: bug with commit d641caa #125

Open
targzeta opened this issue May 30, 2016 · 3 comments
Open

@deb0ch: bug with commit d641caa #125

targzeta opened this issue May 30, 2016 · 3 comments

Comments

@targzeta
Copy link

targzeta commented May 30, 2016

@deb0ch

I have just updated powerline with latest two commits, but see what it's happened:

Before:
screenshot_1464594482

After (UTF-8 character undisplayed):
screenshot_1464594537

Is it something wrong on my config?

Emanuele

@targzeta targzeta changed the title Bug with commit d641caa9bcbab1b8075ce5c157b2579a383683c3 @deb0ch: bug with commit d641caa9bcbab1b8075ce5c157b2579a383683c3 May 30, 2016
@targzeta targzeta changed the title @deb0ch: bug with commit d641caa9bcbab1b8075ce5c157b2579a383683c3 @deb0ch: bug with commit d641caa May 30, 2016
@deb0ch
Copy link
Contributor

deb0ch commented May 30, 2016

Are you using emacs in a terminal (TTY) or in a X window (GUI) in your screenshots ?

What happened is that before there was an if statement to hide that UTF-8 character in GUI and only display it in TTY. I removed that if to display it both in TTY and GUI, but if you are indeed using GUI then I guess that condition was there for a reason.

It is supposed to look like this:
vcs_glyph

I will work on a PR with a configuration variable to show or hide this in GUI.

In the mean time, you can go in powerline.el at line 446 and replace

(defpowerline powerline-vc
  (when (and (buffer-file-name (current-buffer)) vc-mode)
          (format " %s %s" 
                  (char-to-string #xe0a0) 
                  (format-mode-line '(vc-mode vc-mode)))))

with

(defpowerline powerline-vc
  (when (and (buffer-file-name (current-buffer)) vc-mode)
          (format " %s"
                  (format-mode-line '(vc-mode vc-mode)))))

which should stop showing that broken glyph altogether.

@targzeta
Copy link
Author

I was within X window. Here how the powerline looks in a terminal:
screenshot_1464680056

With your suggestion the broken glyph is disappeared.

Emanuele

@deb0ch
Copy link
Contributor

deb0ch commented May 31, 2016

#126 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants