You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off great work and thanks for sharing your solution!
I used your setup as a reference to get the same thing running via serverless framework.
Whilst testing I encountered the issue that I was not able to generate images smaller than w=640, it would say "w" parameter (width) of 256 is not allowed even though it is a valid default imageSize.
Ah yes, good catch!
I will provide a fix for this in the next release (Since we follow the same versioning schema as Next.js we'll have to wait until a new version of Next.js is released).
Thanks for reporting!
Hey!
First off great work and thanks for sharing your solution!
I used your setup as a reference to get the same thing running via serverless framework.
Whilst testing I encountered the issue that I was not able to generate images smaller than w=640, it would say
"w" parameter (width) of 256 is not allowed
even though it is a valid default imageSize.Looking at the code I found the cause. Here, when using the defaults in case of missing envs, the second default should be
imageSizes
and notdeviceSizes
again.https://github.com/dealmore/terraform-aws-next-js-image-optimization/blob/4de6dfb3b241d3a6d99d603e8b047cddaf1937cf/lib/handler.ts#L61
Just wanted to let you know in case anyone is using this without explicit envs and encounters this as well.
Thanks and kind regards,
Daniel
The text was updated successfully, but these errors were encountered: