Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_all_documents_generator does not implement what it promises to #8

Open
apohllo opened this issue Nov 30, 2023 · 0 comments
Open

Comments

@apohllo
Copy link

apohllo commented Nov 30, 2023

The method description says:

Get documents from the document store. Under-the-hood, documents are fetched in batches from the
        document store and yielded as individual documents. This method can be used to iteratively process
        a large number of documents without having to load all documents in memory.

while the implementation is:

for doc in self.get_all_documents(
            index, filters, return_embedding, batch_size, headers
        ):
            yield doc

I think NotImplementedError should be raised for this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant